Fix the ballot encoding #102
Merged
+48
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2234775233Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
We don't need to string-encode the chunks and the do the opposite when encrypting. We can just keep the chunks as `Uint8Array[]`
|
Made an update, we can keep the chunks as |
|
Kudos, SonarCloud Quality Gate passed! |
nkcr
approved these changes
Apr 28, 2022
Excellent (I wasn't sure if it would work with bytes hence the decoding back into strings) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the way the encoded ballot is divided into chunks of 29 bytes (counting the characters resulted in a bug where some chunks
where longer than 29 bytes because of special characters).
A workaround is to first encode into bytes the ballot, divide the resulting array of bytes into chunks of 29 bytes and then decode each chunks back into a string (of 29 bytes) ...