Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds polling on the nodes' state instead of sleeping #109

Merged
merged 3 commits into from
May 10, 2022

Conversation

emduc
Copy link
Contributor

@emduc emduc commented May 2, 2022

Replaces the different sleeps in the integration test by busy polling on the nodes' states; we wait that all the nodes reached a concensus on the desired state, within a given timeout. Timing out raises an error but does not stop the test, this is to get a better understanding of the error: eventually the test will stop on its own but the additional logs after the timeout are useful to understand what goes wrong.

@emduc emduc requested a review from nkcr May 2, 2022 06:58
@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 2275239408

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 51 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 63.841%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/controller/action.go 6 49.38%
services/dkg/pedersen/handler.go 13 84.84%
services/dkg/pedersen/mod.go 32 85.56%
Totals Coverage Status
Change from base Build 2243822141: -0.3%
Covered Lines: 3088
Relevant Lines: 4837

💛 - Coveralls

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@nkcr nkcr added enhancement New feature or request tests labels May 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@emduc emduc merged commit 5c76c50 into main May 10, 2022
@emduc emduc deleted the avoid-sleeps-in-integration-test branch May 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants