Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "combineShares" button #112

Closed
wants to merge 4 commits into from
Closed

Adds "combineShares" button #112

wants to merge 4 commits into from

Conversation

nkcr
Copy link
Contributor

@nkcr nkcr commented May 3, 2022

  • fixes wrong api endpoint
  • updates 'beginDecryption' to 'computePubshares' (will be updated in the API)
  • adds missing "Content-Type"

@nkcr
Adds "combineShares" button
0594518 
- fixes wrong api endpoint
- updates 'beginDecryption' to 'computePubshares' (will be updated in the API)
- adds missing "Content-Type"
@nkcr nkcr requested review from cmsigrist and badrlarhdir May 3, 2022 12:20
@nkcr nkcr self-assigned this May 3, 2022
@coveralls
Copy link

coveralls commented May 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2264818842

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 64.11%
Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 16 86.88%
Totals Coverage Status
Change from base Build 2264561818: -0.3%
Covered Lines: 3101
Relevant Lines: 4837
💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@badrlarhdir badrlarhdir closed this May 3, 2022
@badrlarhdir badrlarhdir deleted the adds-combine-btn branch May 3, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badrlarhdir badrlarhdir badrlarhdir approved these changes

@cmsigrist cmsigrist Awaiting requested review from cmsigrist

Assignees

@nkcr nkcr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkcr @coveralls @badrlarhdir