-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the functionality to delete an election #118
Conversation
Pull Request Test Coverage Report for Build 2282809803Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Adds the functionality to delete an election. Even if everything is on the blockchain, deleting an election will remove it from the global state. Updates all components (smart contract, proxy, web-backend, web-frontend, API doc) accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The web part looks good to me, maybe the implementation in the mock handler would make everything work on the frontend, at least with the mock API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend part looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and sweet 💯
f51415c
to
31bd318
Compare
Kudos, SonarCloud Quality Gate passed! |
Adds the functionality to delete an election. Even if everything is on the blockchain, deleting an election will remove it from the global state.
Updates all components (smart contract, proxy, web-backend, web-frontend, API doc) accordingly.