Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the functionality to delete an election #118

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

nkcr
Copy link
Contributor

@nkcr nkcr commented May 6, 2022

Adds the functionality to delete an election. Even if everything is on the blockchain, deleting an election will remove it from the global state.

Updates all components (smart contract, proxy, web-backend, web-frontend, API doc) accordingly.

@nkcr nkcr added enhancement New feature or request web frontend web backend node backend About the blockchain node labels May 6, 2022
@nkcr nkcr self-assigned this May 6, 2022
@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2282809803

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 66 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 63.638%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/evoting/controller/action.go 0 1 0.0%
contracts/evoting/mod.go 0 5 0.0%
contracts/evoting/types/transactions.go 0 18 0.0%
contracts/evoting/evoting.go 0 42 0.0%
Totals Coverage Status
Change from base Build 2282408953: -0.5%
Covered Lines: 3117
Relevant Lines: 4898

💛 - Coveralls

Adds the functionality to delete an election. Even if everything is on the blockchain, deleting an election will remove it from the global state.

Updates all components (smart contract, proxy, web-backend, web-frontend, API doc) accordingly.
@nkcr nkcr force-pushed the adds-delete-election branch from f4f01ba to 1cf8649 Compare May 6, 2022 16:08
Copy link
Contributor

@badrlarhdir badrlarhdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web part looks good to me, maybe the implementation in the mock handler would make everything work on the frontend, at least with the mock API.

Copy link
Contributor

@giogio21 giogio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend part looks good to me

Copy link
Contributor

@emduc emduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and sweet 💯

@nkcr nkcr force-pushed the adds-delete-election branch from f51415c to 31bd318 Compare May 10, 2022 07:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

@nkcr nkcr merged commit 590dfff into main May 10, 2022
@nkcr nkcr deleted the adds-delete-election branch May 10, 2022 07:56
ineiti added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request node backend About the blockchain node web backend web frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants