Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg status metrics #126

Merged
merged 1 commit into from
May 27, 2022
Merged

dkg status metrics #126

merged 1 commit into from
May 27, 2022

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented May 12, 2022

Added metrics to monitor DKG status

@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2314466662

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 63.231%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.84%
Totals Coverage Status
Change from base Build 2306693646: -0.2%
Covered Lines: 3116
Relevant Lines: 4928

💛 - Coveralls

@jbsv jbsv force-pushed the metrics_dkg_status branch from 8c1e120 to e459f37 Compare May 12, 2022 15:39
@jbsv jbsv force-pushed the metrics_dkg_status branch from e459f37 to 4ef7da6 Compare May 12, 2022 15:45
@jbsv jbsv requested a review from nkcr May 12, 2022 15:46
@jbsv jbsv self-assigned this May 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

17.6% 17.6% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nkcr nkcr merged commit ea48be8 into main May 27, 2022
@nkcr nkcr deleted the metrics_dkg_status branch May 27, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants