Fix Front UI create election #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
badrlarhdir
commented
May 17, 2022
•
badrlarhdir
commented
- Main page
- remove drag and drop for importing JSON and replace it with only text
- padding top main title
- Block default input of titles so i can remove no main title etc.
- default input when importing json is already validated
- Line for remove subject in dropdown
- Rank min/max values to be only one
- Tab for preview in phones
- Problem : working on both phone and laptop without having two different states
- Modal
- 2 col modal
- Add type Icons in modal create question
- MaxN & minN more relevant
- Validation on each question before saving
- Add confirm modal for remove subject
- Preview of the question inside the modal ( TODO later )
nkcr
reviewed
May 30, 2022
| </div> | ||
|
|
||
| <div className="flex mt-2 ml-2"> | ||
| <div className="ml-8">{Type.charAt(0).toUpperCase() + Type.slice(1)}</div> |
There was a problem hiding this comment.
I still think this is not necessary to display the question type in plain text, as there is already the icon.
There was a problem hiding this comment.
I think we made the redundancy on purpose in case someone doesn't understand the icon @cmsigrist .
nkcr
approved these changes
May 30, 2022
|
SonarCloud Quality Gate failed. |
Pull Request Test Coverage Report for Build 2410039949Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.