Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare deb packaging for dvoting without unikernel #132

Merged
merged 6 commits into from
Jun 2, 2022
Merged

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented May 31, 2022

make deb generates an installable, debian package.
Successfully tested on 3 local VMware machines.

@coveralls
Copy link

coveralls commented May 31, 2022

Pull Request Test Coverage Report for Build 2413677222

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.494%

Totals Coverage Status
Change from base Build 2410134754: 0.0%
Covered Lines: 3129
Relevant Lines: 4928

💛 - Coveralls

@jbsv jbsv requested a review from nkcr June 1, 2022 11:13
Copy link
Contributor Author

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Just a minor comment

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jbsv jbsv merged commit 7d5e383 into main Jun 2, 2022
@jbsv jbsv deleted the apt-package branch June 2, 2022 08:17
ineiti added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants