Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview election form & fix UI bugs #133

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Conversation

badrlarhdir
Copy link
Contributor

Adds the preview ballot in the election form

@badrlarhdir badrlarhdir marked this pull request as ready for review May 31, 2022 14:11
@badrlarhdir badrlarhdir requested a review from nkcr May 31, 2022 14:12
@coveralls
Copy link

coveralls commented May 31, 2022

Pull Request Test Coverage Report for Build 2426871778

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 63.231%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.84%
Totals Coverage Status
Change from base Build 2410134754: -0.3%
Covered Lines: 3116
Relevant Lines: 4928

💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@badrlarhdir badrlarhdir requested a review from nkcr June 3, 2022 09:58
@cmsigrist cmsigrist merged commit 9929697 into main Jun 6, 2022
@cmsigrist cmsigrist deleted the front-preview-election branch June 6, 2022 13:26
ineiti pushed a commit that referenced this pull request Oct 10, 2024
Add URL for each candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants