Gets the default proxy with the backend #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the app uses the default proxy provided by the web backend. However users can freely change it. The proxy is saved on the session store to avoid fetching the proxy each time.
nkcr
force-pushed
the
default-proxy-update
branch
from
8eb4384 to
7d3ac91
Compare
Pull Request Test Coverage Report for Build 2455558925
💛 - Coveralls |
cmsigrist
approved these changes
Jun 6, 2022
|
|
||
| const fetchFromBackend = async () => { | ||
| try { | ||
| const response = await fetch('/api/config/proxy'); |
There was a problem hiding this comment.
Suggested change
| const response = await fetch('/api/config/proxy'); | |
| const response = await fetch(endpoints.getProxyConfig); |
| import { CheckIcon, PencilIcon, RefreshIcon } from '@heroicons/react/outline'; | ||
| import { FlashContext, FlashLevel, ProxyContext } from 'index'; | ||
| import { ChangeEvent, FC, createRef, useContext, useEffect, useState } from 'react'; | ||
|
|
There was a problem hiding this comment.
Suggested change
| import * as endpoints from './Endpoints'; | |
web/frontend/src/index.tsx
Outdated
| let proxy = sessionStorage.getItem('proxy'); | ||
|
|
||
| if (proxy === null) { | ||
| const response = await fetch('/api/config/proxy'); |
There was a problem hiding this comment.
endpoints.getProxyConfig can also be used here :D
|
Kudos, SonarCloud Quality Gate passed! |
ineiti
added a commit
that referenced
this pull request
Oct 10, 2024
Following latest dela main and fixing local_forms.sh with new JSON format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the app uses the default proxy provided by the web backend. However users can freely change it. The proxy is saved on the session store to avoid fetching the proxy each time.