Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ballot encoding, and the results page #143

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Fix ballot encoding, and the results page #143

merged 2 commits into from
Jun 20, 2022

Conversation

cmsigrist
Copy link
Contributor

  • The ID of each question is now encoded in base64 in the encoded ballot
  • Fix the results page (it used to crash when one of the ballot was invalid)

@coveralls
Copy link

coveralls commented Jun 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2523857366

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.511%
Totals Coverage Status
Change from base Build 2515664144: 0.0%
Covered Lines: 3133
Relevant Lines: 4933
💛 - Coveralls

@cmsigrist cmsigrist requested a review from nkcr June 19, 2022 10:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cmsigrist cmsigrist merged commit b1048e0 into main Jun 20, 2022
@cmsigrist cmsigrist deleted the front-fix-result branch June 20, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcr nkcr nkcr approved these changes

Assignees
No one assigned
Labels
web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmsigrist @coveralls @nkcr