Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ballot encoding #144

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix the ballot encoding #144

merged 2 commits into from
Jun 21, 2022

Conversation

cmsigrist
Copy link
Contributor

Fix the ballot encoding: padding is added until the size of the encoded ballot is equal to the BallotSize.

@cmsigrist cmsigrist added documentation Improvements or additions to documentation web frontend labels Jun 20, 2022
@cmsigrist cmsigrist requested review from nkcr and emduc June 20, 2022 15:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

nkcr
nkcr approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to wait on a second eye from @emduc :)

emduc
emduc approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@emduc emduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me ! Thanks for the update

@coveralls
Copy link

coveralls commented Jun 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2529870182

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.511%
Totals Coverage Status
Change from base Build 2528958278: 0.0%
Covered Lines: 3133
Relevant Lines: 4933
💛 - Coveralls

@nkcr nkcr merged commit cb0abb6 into main Jun 21, 2022
@nkcr nkcr deleted the front-fix-encode branch June 21, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcr nkcr nkcr approved these changes

@emduc emduc emduc approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmsigrist @coveralls @nkcr @emduc