Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize ballot unmarshall #147

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Modularize ballot unmarshall #147

merged 10 commits into from
Jun 22, 2022

Conversation

emduc
Copy link
Contributor

@emduc emduc commented Jun 22, 2022

Small PR to clean up the method to unmarshall ballots. Also adapts the tests for the ballots after the changes made to link the front end.

@emduc emduc requested a review from nkcr June 22, 2022 07:37
@emduc emduc added tests node backend About the blockchain node labels Jun 22, 2022
@coveralls
Copy link

coveralls commented Jun 22, 2022

Pull Request Test Coverage Report for Build 2541336196

  • 92 of 114 (80.7%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.6%) to 62.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/evoting/types/ballots.go 92 114 80.7%
Files with Coverage Reduction New Missed Lines %
contracts/evoting/types/election.go 2 15.79%
contracts/evoting/types/ballots.go 27 83.33%
Totals Coverage Status
Change from base Build 2535659071: 1.6%
Covered Lines: 3101
Relevant Lines: 4959

💛 - Coveralls

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Got a few comments

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

65.5% 65.5% Coverage
0.0% 0.0% Duplication

@emduc emduc requested a review from nkcr June 22, 2022 09:45
@emduc emduc merged commit 32fec58 into main Jun 22, 2022
@emduc emduc deleted the modularize-ballot-unmarshall branch June 22, 2022 09:53
ineiti pushed a commit that referenced this pull request Oct 10, 2024
Add AdditionalInfo field
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2541336196

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 92 of 114 (80.7%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.6%) to 62.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/evoting/types/ballots.go 92 114 80.7%
Files with Coverage Reduction New Missed Lines %
contracts/evoting/types/election.go 2 15.79%
contracts/evoting/types/ballots.go 27 83.33%
Totals Coverage Status
Change from base Build 2535659071: 1.6%
Covered Lines: 3101
Relevant Lines: 4959

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 2540981190

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 114 of 114 (100.0%) changed or added relevant lines in 1 file are covered.
  • 41 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+2.8%) to 63.732%

Files with Coverage Reduction New Missed Lines %
contracts/evoting/types/ballots.go 1 98.89%
contracts/evoting/types/election.go 40 20.29%
Totals Coverage Status
Change from base Build 2535659071: 2.8%
Covered Lines: 3163
Relevant Lines: 4963

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node backend About the blockchain node tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants