Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Dela+Go and fixes the tests #163

Merged
merged 10 commits into from
Sep 8, 2022
Merged

Updates Dela+Go and fixes the tests #163

merged 10 commits into from
Sep 8, 2022

Conversation

nkcr
Copy link
Contributor

@nkcr nkcr commented Sep 5, 2022

  • Uses the latest version of Dela
  • Fixes the tests (encoding of ballot ID, warnings instead of errors)
  • Uses Go 1.19
  • Cleans some parts (removes prints, formats lines)

@nkcr
Updates Dela+Go and fixes the tests
5777176 
- Uses the latest version of Dela
- Fixes the tests (encoding of ballot ID, warnings instead of errors)
- Uses Go 1.19
- Cleans some parts (removes prints, formats lines)
@nkcr nkcr self-assigned this Sep 5, 2022
@coveralls
Copy link

coveralls commented Sep 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3015231322

  • 146 of 187 (78.07%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 63.373%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/evoting/controller/action.go 0 6 0.0%
services/dkg/pedersen/handler.go 136 171 79.53%
Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 11 83.8%
Totals Coverage Status
Change from base Build 2747431647: 0.8%
Covered Lines: 3149
Relevant Lines: 4969
💛 - Coveralls

@nkcr nkcr requested a review from emduc September 5, 2022 09:51
emduc
emduc approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@emduc emduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me, thanks for the request! :)
It's much clearer with warnings instead of errors indeed.

@nkcr nkcr force-pushed the updates-and-test-fixes branch from 40b5393 to 146dff0 Compare September 6, 2022 09:07
@nkcr nkcr force-pushed the updates-and-test-fixes branch 2 times, most recently from 38b5a09 to 2c39564 Compare September 6, 2022 11:01
@nkcr nkcr force-pushed the updates-and-test-fixes branch from 2c39564 to 3fda1cc Compare September 6, 2022 11:15
@nkcr
Copy link
Contributor Author

nkcr commented Sep 7, 2022

Wow, all tests passing. Haven't see that for a while 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

48.5% 48.5% Coverage
0.2% 0.2% Duplication

@nkcr nkcr merged commit b6a48be into main Sep 8, 2022
@nkcr nkcr deleted the updates-and-test-fixes branch September 8, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emduc emduc emduc approved these changes

Assignees

@nkcr nkcr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkcr @coveralls @emduc