Refactoring runComment in mod.go #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3314275046Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nkcr
suggested changes
Oct 24, 2022
internal/mcheck/mod.go
Outdated
| } | ||
| } | ||
|
|
||
| // It loops over all the files in the package, and for each file it loops |
There was a problem hiding this comment.
Suggested change
| // It loops over all the files in the package, and for each file it loops | |
| // runComment loops over all the files in the package, and for each file it loops |
internal/mcheck/mod.go
Outdated
Comment on lines
70
to
72
| // - `//go:generate` | ||
| // - `// http://` | ||
| // - `// https://` |
There was a problem hiding this comment.
I would treat that as code comment (i.e. just indent the line)
|
Kudos, SonarCloud Quality Gate passed!
|
nkcr
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced its cognitive complexity of 41 and added documentation