ensure submitted ballot is correct size and with non empty ElG Pairs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcr
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Nice 👍
Just a question: what happens if the ballot is not encrypted with the public key ? I guess it would just end with a garbage decrypted ballot, but until we are sure about that I would create a new issue for this specific case, before closing #17 .
contracts/evoting/mod_test.go
Outdated
| @@ -192,6 +192,56 @@ func TestCommand_CastVote(t *testing.T) { | |||
| dummyElection.Status = types.Open | |||
| jsElection, _ = json.Marshal(dummyElection) | |||
|
|
|||
| _ = snap.Set(dummyElectionIdBuff, jsElection) | |||
There was a problem hiding this comment.
you should not ignore an error
Good question, I added a ballot from a different public key in the scenario test and the decryption seems to never end :(. (#26 ) |
nkcr
approved these changes
Dec 22, 2021
pierluca
pushed a commit
that referenced
this pull request
Oct 5, 2023
chore: fix Docker image build CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #17 to ensure that when a vote is casted, it's non empty and it won't fail the shuffle