Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve login Redirection #262

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Improve login Redirection #262

merged 9 commits into from
Jan 18, 2023

Conversation

aelalamy42
Copy link
Contributor

This pull requests aims to improve the redirection after login.
Before: Everytime we would login we would be redirected to the main page of the website which was inconvenient.
Now: Using cookies we are always redirected to the page from which we clicked on the login button.

@aelalamy42 aelalamy42 requested a review from nkcr December 29, 2022 10:26
@aelalamy42 aelalamy42 requested a review from a team as a code owner December 29, 2022 10:26
@aelalamy42 aelalamy42 self-assigned this Dec 29, 2022
@coveralls
Copy link

coveralls commented Dec 29, 2022

Pull Request Test Coverage Report for Build 3812559079

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 56.768%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 3 87.21%
Totals Coverage Status
Change from base Build 3765718917: -0.05%
Covered Lines: 3271
Relevant Lines: 5762

💛 - Coveralls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aelalamy42 aelalamy42 requested a review from nkcr January 13, 2023 12:31
@Khadija21102 Khadija21102 merged commit f8f4fc5 into main Jan 18, 2023
@Khadija21102 Khadija21102 deleted the aelalamy-login-redirect branch January 18, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants