Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX : Change the mock data to make it work with hint button + Minor Display Issue #264

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

aelalamy42
Copy link
Contributor

A bug was found where the mocks were not working anymore because they were not giving an empty hint button text and made the website crash. This PR aims to fix this bug

@aelalamy42 aelalamy42 requested a review from a team as a code owner December 29, 2022 13:23
@aelalamy42 aelalamy42 self-assigned this Dec 29, 2022
@coveralls
Copy link

coveralls commented Dec 29, 2022

Pull Request Test Coverage Report for Build 3801208093

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 56.768%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 3 87.21%
Totals Coverage Status
Change from base Build 3765718917: -0.05%
Covered Lines: 3271
Relevant Lines: 5762

💛 - Coveralls

@aelalamy42 aelalamy42 changed the title BUGFIX : Change the mock data to make it work with hint button BUGFIX : Change the mock data to make it work with hint button + Minor Display Issue Dec 29, 2022
@aelalamy42
Copy link
Contributor Author

I also found an issue where when casting a ballot, the hint button would appear near the center of the page whereas when hovering the actual hint text would appear at the total right of the page. I fixed that by assuring that the hint button was aligned at the right instead of in the middle

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aelalamy42 aelalamy42 merged commit 92df6d6 into main Jan 12, 2023
@aelalamy42 aelalamy42 deleted the mock-update-hintbutton-aelalamy branch January 12, 2023 13:19
@aelalamy42 aelalamy42 restored the mock-update-hintbutton-aelalamy branch January 16, 2023 17:01
@aelalamy42 aelalamy42 deleted the mock-update-hintbutton-aelalamy branch January 16, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants