Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overhauled Docker environment #299

Merged
merged 16 commits into from
Aug 28, 2023
Merged

fix: overhauled Docker environment #299

merged 16 commits into from
Aug 28, 2023

Conversation

PascalinDe
Copy link
Contributor

@PascalinDe PascalinDe commented Aug 9, 2023 •
edited
Loading

  • cleaned up exposed ports
  • added persistent storage to Dela nodes
  • added reverse proxy to backend to avoid CORS issues

@PascalinDe PascalinDe requested a review from a team as a code owner August 9, 2023 15:20
@PascalinDe PascalinDe force-pushed the fix-ports branch 5 times, most recently from 722fa7d to 4e771aa Compare August 11, 2023 08:32
@PascalinDe PascalinDe changed the title fix: do not expose unnecessary ports and add details in README.docker.md as to which hostnames should be used fix: overhauled Docker environment Aug 11, 2023
lanterno
lanterno reviewed Aug 16, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5964749686

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 57.444%
Totals Coverage Status
Change from base Build 5952706384: 0.05%
Covered Lines: 3272
Relevant Lines: 5696
💛 - Coveralls

lanterno
lanterno reviewed Aug 22, 2023
View reviewed changes
@PascalinDe PascalinDe force-pushed the fix-ports branch 2 times, most recently from 2364686 to cc8afc3 Compare August 22, 2023 15:07
lanterno
lanterno previously approved these changes Aug 22, 2023
View reviewed changes
pierluca
pierluca reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, minor remarks.

init_dela.sh Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be run automatically as part of the initial docker compose up ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script is mainly for us for the moment, as you noted yourself it's not very robust, and supposed to be removed/improved anyway, is it OK to leave it like this for the moment so that we can move forward on this branch?

I opened a ticket here: #308

@PascalinDe PascalinDe force-pushed the fix-ports branch 2 times, most recently from fafebc9 to 85b26cb Compare August 24, 2023 10:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PascalinDe PascalinDe mentioned this pull request Aug 28, 2023
Closed
@PascalinDe PascalinDe merged commit 42a37a0 into main Aug 28, 2023
@PascalinDe PascalinDe deleted the fix-ports branch August 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluca pierluca pierluca approved these changes

@lanterno lanterno lanterno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PascalinDe @coveralls @lanterno @pierluca