Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming memcoin to dvoting #355

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Renaming memcoin to dvoting #355

merged 1 commit into from
Sep 13, 2023

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Sep 13, 2023

Making sure the name of the binary makes sense.

@ineiti
Renaming memcoin to dvoting
2ac3767 
Making sure the name of the binary makes sense.
@ineiti ineiti requested a review from a team as a code owner September 13, 2023 09:39
@ineiti ineiti self-assigned this Sep 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ineiti ineiti requested a review from pierluca September 13, 2023 09:57
emduc
emduc approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@emduc emduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense if it doesn't conflict with existing files

PascalinDe
PascalinDe approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ineiti ineiti merged commit 9491350 into main Sep 13, 2023
@ineiti ineiti deleted the memcoin_dvoting branch September 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalinDe PascalinDe PascalinDe approved these changes

@emduc emduc emduc approved these changes

@pierluca pierluca Awaiting requested review from pierluca

Assignees

@ineiti ineiti

Labels
None yet
Projects
D-voting C4DT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ineiti @PascalinDe @emduc