Guanyu/rewrite/scenariotest #79
Conversation
JBGYZ
commented
Apr 7, 2022
JBGYZ
commented
- Finished scenario test with http
- added 2 fields in getelectioninfo response
and voter's initial votes
and decrypted votes
|
Guanyu Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
I made a quick pass on it since I am starting to try and solve this shuffle problem, this new version will definitely be helpful thank you :)
I know it wasn't the case in the original scenario test but it could be nice to have the test be generic in the number of nodes and votes, similarly to what is done in integration_test.go. It should not be too difficult to implement (just a matter of having for eg arrays of addresses instead of addr1 addr2 and addr3) but might take some time.
edit: actually that might be more annoying since we need to launch the nodes seperately
Depending on who merges first, the problem of signed request will also arise since the proxy will soon require the requests to be signed.
integration/scenario_test.go
Outdated
| proxyArray := [3]string{proxyAddr1, proxyAddr2, proxyAddr3} | ||
|
|
||
| // ###################################### CREATE SIMPLE ELECTION ###### | ||
| create_election_js := `{"Configuration":{"MainTitle":"electionTitle","Scaffold":[{"ID":"YWE=","Title":"subject1","Order":null,"Subjects":null,"Selects":[{"ID":"YmI=","Title":"Select your favorite snacks","MaxN":3,"MinN":0,"Choices":["snickers","mars","vodka","babibel"]}],"Ranks":[],"Texts":null},{"ID":"ZGQ=","Title":"subject2","Order":null,"Subjects":null,"Selects":null,"Ranks":null,"Texts":[{"ID":"ZWU=","Title":"dissertation","MaxN":1,"MinN":1,"MaxLength":3,"Regex":"","Choices":["write yes in your language"]}]}]},"AdminID":"adminId"}` |
There was a problem hiding this comment.
would be good to add some returns so that we can read the content of the configuration easily
Pull Request Test Coverage Report for Build 2264717034Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Kudos, SonarCloud Quality Gate passed! |
