Initialize ServerIdentities for local tests #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fixing a missing test in byzcoin, I saw that the ServerIdentities are not fully initialized for local tests. As the new configuration contract in byzcoin also checks for Address and Description in the ServerIdentity, they also must be set for local tests. Once this PR is merged, the onet version should be increased.
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 14, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
nkcr
reviewed
Apr 15, 2021
local.go
Outdated
| @@ -487,6 +487,8 @@ func NewPrivIdentity(suite network.Suite, port int) (kyber.Scalar, *network.Serv | |||
| kp := key.NewKeyPair(suite) | |||
| id := network.NewServerIdentity(kp.Public, address) | |||
| ServiceFactory.generateKeyPairs(id) | |||
| id.Address = address | |||
There was a problem hiding this comment.
Seems useless as this is already done in NewServerIdentity.
There was a problem hiding this comment.
The PR is getting very small ;)
There was a problem hiding this comment.
|
Kudos, SonarCloud Quality Gate passed!
|
nkcr
approved these changes
Apr 15, 2021
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
ineiti
added a commit
to dedis/cothority
that referenced
this pull request
Apr 15, 2021
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
nkcr
pushed a commit
to dedis/kyber-java
that referenced
this pull request
May 17, 2022
The byzcoin contract did not correctly check for new nodes in a new proposed roster, this led to a wrong node being stored in the chain. The bcadmin did not correctly load the public files of a new node, a node to be deleted, or a node for a leader change. Both are fixed in this PR. It depends on dedis/onet#676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing a missing test in byzcoin, I saw that the ServerIdentities are not fully
initialized for local tests. As the new configuration contract in byzcoin also
checks for Address and Description in the ServerIdentity, they also must be
set for local tests.
Once this PR is merged, the onet version should be increased.