Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Signal's getFileDescriptorOwner with K-9's SafeContentResolver #2976

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Replace Signal's getFileDescriptorOwner with K-9's SafeContentResolver #2976

merged 3 commits into from
Apr 13, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Mar 7, 2024 •
edited
Loading

Closes #2975

@r10s
Copy link
Member

r10s commented Mar 7, 2024

This probably breaks something

maybe not. i commented a bit at #2975 (comment)

@link2xt link2xt force-pushed the link2xt/getFileDescriptorOwner branch from 3c44efa to 3d8ec8b Compare March 8, 2024 03:47
@link2xt link2xt marked this pull request as ready for review March 8, 2024 03:47
@link2xt link2xt marked this pull request as draft March 8, 2024 03:56
@link2xt link2xt marked this pull request as ready for review March 8, 2024 04:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt link2xt changed the title Remove getFileDescriptorOwner Replace Signal's getFileDescriptorOwner with K-9's SafeContentResolver Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s
r10s reviewed Mar 9, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks! i think, this is a very good solution now

as we're currently rolling out 1.44, to avoid additional moving targets, we'd better merge this when 1.44 is really out and stable (usually, there are some minor updates needed :)

@r10s r10s added the wait-for-merge-window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Mar 9, 2024
@r10s r10s requested a review from adbenitez April 2, 2024 10:56
@r10s r10s removed the wait-for-merge-window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Apr 2, 2024
adbenitez
adbenitez approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! nice improvement

@link2xt link2xt merged commit 430c158 into main Apr 13, 2024
2 checks passed
@link2xt link2xt deleted the link2xt/getFileDescriptorOwner branch April 13, 2024 18:52
@link2xt link2xt mentioned this pull request Apr 13, 2024
Open
@adbenitez adbenitez mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@adbenitez adbenitez adbenitez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of FileUtils.getFileDescriptorOwner
3 participants
@link2xt @r10s @adbenitez