Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add "module.exports" export to ESM CJS wrapper module #28373

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: add "module.exports" export to ESM CJS wrapper module #28373

merged 1 commit into from
Mar 3, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 3, 2025 •
edited
Loading

Part of #28352 (need to ensure require esm uses this after)

marvinhagemeister
marvinhagemeister approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret
Copy link
Member Author

dsherret commented Mar 3, 2025 •
edited
Loading

I don't think node is actually doing "module.exports" on import(cjs),

It is. See the linked PR in Node.js.

my issue was just about supporting it for require(esm)

See the PR description: "need to ensure require esm uses this after" (I'll do this after this PR. This does not close that issue)

@dsherret dsherret enabled auto-merge (squash) March 3, 2025 16:13
@dsherret dsherret merged commit a566d8b into denoland:main Mar 3, 2025
18 checks passed
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@dsherret @littledivy
fix: add "module.exports" export to ESM CJS wrapper module (#28373)
8570051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @marvinhagemeister