Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add concurrent feature #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xusd320
Copy link

@xusd320 xusd320 commented Mar 6, 2025

The swc Lock will fallback to RefCell when concurrent feature is not enabled, see https://github.com/swc-project/swc/blob/9676c9acc83cca4297f07abdc203f0ab8da36b2b/crates/swc_common/src/sync.rs#L37.

Closes #219
Closes #250

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@xusd320 xusd320 force-pushed the feat/sync-feature branch 3 times, most recently from 2542f32 to 64402ab Compare March 6, 2025 11:28
@dsherret dsherret changed the title feat: add sync feature feat: add concurrent feature Mar 6, 2025
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you apply this patch?

patch.patch

@xusd320 xusd320 force-pushed the feat/sync-feature branch from 64402ab to 400288b Compare March 6, 2025 15:04
@xusd320
Copy link
Author

xusd320 commented Mar 6, 2025

Thanks. Can you apply this patch?

patch.patch

Absolutely ! That's done.

@xusd320 xusd320 force-pushed the feat/sync-feature branch from 400288b to e928dc1 Compare March 7, 2025 01:35
@xusd320 xusd320 requested a review from dsherret March 7, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using deno_ast in a project that contains swc_common -F concurrent breaks the build
3 participants