Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pension - Update VA Medical Center pages #35216

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

ToddWebDev
Copy link
Contributor

@ToddWebDev ToddWebDev commented Mar 12, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes

Did you change site-wide styles, platform utilities or other infrastructure?

  • No
  • Yes

Summary

Summary of changes on the Pension Benefits form (21P-527EZ)

Associated Pull Request(s)

How to run in local environment

  1. Check out this branch locally
  2. Run vets-website and vets-api
  3. In your local environment, set the pension_multiple_page_response flipper to 'enabled' at http://localhost:3000/flipper/features/pension_multiple_page_response
  4. Go to http://localhost:3001/pension/apply-for-veteran-pension-form-21p-527ez/ in your browser

How to verify

  1. Sign in and verify that VA Medical Center pages are able to be filled out and successfully submitted

What areas of the site does it impact?

Pension Benefits Application

Screenshots

n/a

Quality Assurance & Testing

  • New unit tests (if applicable)
  • New E2E tests added (if applicable)
  • Existing unit tests and integration tests are passing
  • Existing E2E tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot style, layout and content matches the design references
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@ToddWebDev ToddWebDev added the pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832) label Mar 12, 2025
@ToddWebDev
Copy link
Contributor Author

Unit tests will pass once -department-of-veterans-affairs/vets-json-schema#983 is merged and pulled into vets-website

@va-vfs-bot va-vfs-bot temporarily deployed to master/pension-update-va-medical-center-pages/main March 13, 2025 19:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/pension-update-va-medical-center-pages/main March 14, 2025 14:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/pension-update-va-medical-center-pages/main March 17, 2025 17:09 Inactive
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@ToddWebDev ToddWebDev merged commit c22615b into main Mar 18, 2025
92 checks passed
@ToddWebDev ToddWebDev deleted the pension-update-va-medical-center-pages branch March 18, 2025 16:08
amponce pushed a commit that referenced this pull request Mar 19, 2025
* update form data property

* Update vets-json-schema version
acaruso-oddball pushed a commit that referenced this pull request Mar 25, 2025
* update form data property

* Update vets-json-schema version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants