Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confirmation page feature toggle implementation #35271

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

ToddWebDev
Copy link
Contributor

@ToddWebDev ToddWebDev commented Mar 17, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes

Did you change site-wide styles, platform utilities or other infrastructure?

  • No
  • Yes

Summary

Remove confirmation page updates feature toggle implementation on the Pension Benefits form (21P-527EZ)

Issue

Related issue(s)

n/a

Associated Pull Request(s)

n/a

How to run in local environment

  1. Check out this branch locally
  2. Run vets-website and vets-api
  3. In your local environment, set the pension_form_enabled flipper to 'enabled' at http://localhost:3000/flipper/features/pension_form_enabled
  4. Go to http://localhost:3001/pension/apply-for-veteran-pension-form-21p-527ez/ in your browser

How to verify

  1. Sign in and complete form with valid form data
  2. Successfully submit the form
  3. Verify the default content on the confirmation page

What areas of the site does it impact?

Pension Benefits Application

Screenshots

Desktop

Before After
staging va gov_pension_apply-for-veteran-pension-form-21p-527ez_confirmation localhost_3001_pension_apply-for-veteran-pension-form-21p-527ez_introduction (3)

Quality Assurance & Testing

  • New unit tests (if applicable)
  • New E2E tests added (if applicable)
  • Existing unit tests and integration tests are passing
  • Existing E2E tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot style, layout and content matches the design references
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG - Thanks for the screenshots!

@ToddWebDev ToddWebDev merged commit 78b804e into main Mar 18, 2025
87 checks passed
@ToddWebDev ToddWebDev deleted the pension-89966-remove-confirmation-page-toggle branch March 18, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants