Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade moment to 2.24.0 #6922

Merged
merged 1 commit into from
Mar 8, 2019
Merged

chore: Upgrade moment to 2.24.0 #6922

merged 1 commit into from
Mar 8, 2019

Conversation

vhashimotoo
Copy link
Contributor

Overview

Closes #6921

Description

  • Upgrades moment from 2.17.1 to 2.24.0 for fix vulnerability.

Verification

  • the history view - each commit shows a relative time in the description up until some limit, then it switches to the absolute time

2019-02-22 18 22 15

  • the fetch button shows the relative time

2019-02-22 18 23 06

  • the branches list shows the time of the last commit to each branch

2019-02-22 18 23 31

Release notes

Notes: no-notes

@shiftkey shiftkey added tech-debt Issues and pull requests related to addressing technical debt or improving the codebase ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Feb 22, 2019
@iAmWillShepherd iAmWillShepherd self-assigned this Feb 22, 2019
@iAmWillShepherd
Copy link
Contributor

This doesn't really need to sit any longer.

@iAmWillShepherd iAmWillShepherd merged commit 5d9eab1 into desktop:development Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iAmWillShepherd iAmWillShepherd iAmWillShepherd approved these changes

Assignees

@iAmWillShepherd iAmWillShepherd

Labels
ready-for-review Pull Requests that are ready to be reviewed by the maintainers tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade moment dependency
3 participants
@vhashimotoo @iAmWillShepherd @shiftkey