Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of electron_mass_eV #179

Closed
jank324 opened this issue Jun 18, 2024 · 0 comments · Fixed by #189
Closed

Refactoring of electron_mass_eV #179

jank324 opened this issue Jun 18, 2024 · 0 comments · Fixed by #189
Labels
good first issue Good for newcomers

Comments

@jank324
Copy link
Member

jank324 commented Jun 18, 2024

These are the same. This can be refactored in quite a few files. I prefer electron_mass_eV as a name and the way it is defined.

rest_energy = torch.tensor(
    constants.electron_mass
    * constants.speed_of_light**2
    / constants.elementary_charge  # electron mass
)
electron_mass_eV = torch.tensor(
    physical_constants["electron mass energy equivalent in MeV"][0] * 1e6
)
@jank324 jank324 changed the title Refactoring of electron mass eV Refactoring of electron_mass_eV Jun 18, 2024
@jank324 jank324 added the good first issue Good for newcomers label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant