Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify constants for electron mass #189

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

Hespe
Copy link
Member

@Hespe Hespe commented Jun 19, 2024

Description

In many files there were two identical constants for the electron mass. The duplication is removed and unused imports are deleted.

Motivation and Context

Closes #179

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Internal refactoring

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324
Copy link
Member

jank324 commented Jun 19, 2024

@Hespe can you add this to the changelog under Other? Then we can also merge this.

@jank324 jank324 merged commit a35fc03 into desy-ml:master Jun 19, 2024
6 checks passed
@Hespe Hespe deleted the 179-electron-mass-constants branch June 19, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring of electron_mass_eV
2 participants