Fix the batch execution for elements with tilts or misalignments #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr-xu
changed the title
jank324
reviewed
May 21, 2024
tests/test_tilted_elements.py
Outdated
| @@ -0,0 +1,51 @@ | |||
| import torch | |||
There was a problem hiding this comment.
@cr-xu Is there a reason you didn't just put these into test_quadrupole.py? That seems more logical to me.
jank324
reviewed
May 21, 2024
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| - Now all `Element` have a default length of `torch.zeros((1))`, fixing occasional issues with using elements without length, such as `Marker`, `BPM`, `Screen`, and `Aperture`. (see #143) (@cr-xu) | |||
| - Fix bug in `Cavity` `_track_beam` (see [#150](https://github.com/desy-ml/cheetah/issues/150)) (@jp-ga) | |||
| - Fix bugs when tracking elements with `tilt` or `misalignment`. (see #157) (@cr-xu) | |||
There was a problem hiding this comment.
@cr-xu Did you fix anything other than the vectorisation? I guess because the changelog is with respect to the previous release (and not master), rather than adding a bug fix, we should add the issue and your name to the breaking vectorisation change entry. Does that make sense?
There was a problem hiding this comment.
No, that's only with the vectorisation. Yes it makes sense to move it in the vectorisation entry.
jank324
deleted the
154-missing-batch-execution-compatibility-in-dipole-rotation-matrix-etc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Closes #154.
Types of changes
Checklist
flake8(required).pytesttests pass (required).pyteston a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line