Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cavity tracking issue introduced in recent updates #172

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

cr-xu
Copy link
Member

@cr-xu cr-xu commented Jun 12, 2024

  • Fix a missing sign in the cavity tracking method (v0.6.3 was not affected. This was introduced somewhere in the batched execution upgrade Vectorised simulations #116, but remains unidentified as the test was still passing with some rtol)
  • Remove large rtols in the related test as they are no longer required.
  • Add an additional test identifying the issue with non-zero RF phase

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@cr-xu cr-xu added the bug Something isn't working label Jun 12, 2024
@cr-xu cr-xu marked this pull request as ready for review June 12, 2024 15:08
@cr-xu cr-xu requested a review from jank324 June 12, 2024 15:08
@cr-xu cr-xu self-assigned this Jun 12, 2024
@jank324 jank324 merged commit 57d287e into master Jun 12, 2024
11 checks passed
@jank324 jank324 deleted the fix-cavity-tracking-issue branch June 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants