-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vectorization issue in rbend #173
Conversation
cheetah/accelerator/dipole.py
Outdated
# non_zero_mask = self.length != 0 | ||
# value[non_zero_mask] = self.angle[non_zero_mask] / self.length[non_zero_mask] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# non_zero_mask = self.length != 0 | |
# value[non_zero_mask] = self.angle[non_zero_mask] / self.length[non_zero_mask] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is there a reason those comments should be there?
Also, the PR number should be added to the changelog entry. |
@cr-xu if you didn't have an important reason to keep the comment, I think this PR can now just be merged as is. |
Thanks for the changes! I forgot to remove the comments. |
RBend
construction method was not properly updated with the vectorization feature Vectorised simulations #116Dipole
to clearly mention that by default a sector bend is generated.Description
Motivation and Context
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line