Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift name #201

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Drift name #201

merged 3 commits into from
Jun 27, 2024

Conversation

ansantam
Copy link
Collaborator

Description

Adding name to Drift element.

Motivation and Context

When Cheetah does not recognize an element it transforms it to a Drift of the corresponding length to keep the correct element positions. It is useful to have the element name attached to the Drift in case the original one was not a drift, for better understanding of the lattice when inspecting the Segment.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@ansantam ansantam added the bug Something isn't working label Jun 27, 2024
@ansantam ansantam requested a review from jank324 June 27, 2024 16:13
@jank324 jank324 merged commit 304da87 into desy-ml:master Jun 27, 2024
6 checks passed
@ansantam ansantam deleted the drift_name branch June 28, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants