Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cavity being broken by vectorisation #215

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Jul 9, 2024

Description

Re-adds the use of base_rmatrix for Cavitys with voltage=0.0 because the usually cavity matrix breaks in that case. This was originally removed with the vectorisation because it was difficult to integrate and though to be unnecessary.

Motivation and Context

Closes #214.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324 jank324 linked an issue Jul 9, 2024 that may be closed by this pull request
@jank324 jank324 added the bug Something isn't working label Jul 9, 2024
@jank324 jank324 marked this pull request as ready for review July 9, 2024 21:56
@jank324 jank324 self-assigned this Jul 9, 2024
@jank324 jank324 requested a review from cr-xu July 9, 2024 21:57
@cr-xu
Copy link
Member

cr-xu commented Jul 10, 2024

The failing test is actually related to the broadcast defaulting to float32 #217

@jank324
Copy link
Member Author

jank324 commented Jul 10, 2024

The failing test is actually related to the broadcast defaulting to float32 #217

I've merged #218 and now they are passing.

@cr-xu cr-xu merged commit d0854de into master Jul 10, 2024
11 checks passed
@jank324 jank324 deleted the 214-vectorised-cavity-is-broken branch July 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorised cavity is broken
2 participants