-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bmad-X Drift Dipole and Transverse Deflecting Cavity #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So as far as I'm concerned, this PR is fine, except for the docstring and type annotation that's missing. @jp-ga, I think you are in the best position to add those.
I'm not sure if the plot
function is an issue. @jp-ga, @cr-xu what are your thoughts?
Aside from that, I fixed an issue that always cast everything to torch.float64
. This was rooted in a general issue in Cheetah, where constant floating point numbers were cast to tensors when they didn't have to be.
Sounds good, I will work on the changes. I can also change the color of the TDC. |
Description
Adds Bmad-X tracking routines to
Drift
andDipole
, and adds a newElement
: aTransverseDeflectingCavity
Motivation and Context
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.