Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin numpy<2.0 #242

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Unpin numpy<2.0 #242

merged 4 commits into from
Sep 5, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Aug 26, 2024

Description

Removes the requirement that a version of numpy<2.0 must be installed.

Motivation and Context

See #177. It would be nice to allow for NumPy 2, which has so far resulted in errors coming from PyTorch because the latter fails to pin to a compatible NumPy version or compile PyTorch for compatibility with NumPy 2 on Windows. I thought this was fixed now, but apparently it still fails.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@jank324 jank324 added the enhancement New feature or request label Aug 26, 2024
@jank324 jank324 linked an issue Aug 26, 2024 that may be closed by this pull request
@jank324 jank324 marked this pull request as draft August 26, 2024 09:33
@Hespe Hespe self-requested a review August 30, 2024 14:42
@Hespe Hespe marked this pull request as ready for review August 30, 2024 14:42
@Hespe Hespe marked this pull request as draft August 30, 2024 14:44
@Hespe Hespe requested review from Hespe and removed request for Hespe August 30, 2024 14:45
@Hespe Hespe marked this pull request as ready for review September 5, 2024 09:23
@Hespe
Copy link
Member

Hespe commented Sep 5, 2024

@jank324 Seems like we can go ahead and unpin numpy again

@jank324 jank324 merged commit 2b97da4 into master Sep 5, 2024
8 checks passed
@jank324 jank324 deleted the 177-numpy-v200-compatibility branch September 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy v2.0.0 compatibility
2 participants