Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorized tracking for TransverseDeflectingCavity #278

Merged

Conversation

cr-xu
Copy link
Member

@cr-xu cr-xu commented Oct 16, 2024

Description

Adds some missing dimensional expansions in the TransverseDeflectingCavity code to fix a bug with some vectorisation setups.

Motivation and Context

Fixes #270.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@cr-xu cr-xu linked an issue Oct 16, 2024 that may be closed by this pull request
@cr-xu cr-xu requested a review from jank324 October 16, 2024 13:16
@cr-xu cr-xu marked this pull request as ready for review October 16, 2024 13:16
@cr-xu cr-xu added the bug Something isn't working label Oct 16, 2024
@cr-xu cr-xu self-assigned this Oct 16, 2024
@jank324 jank324 changed the title Fixes 270 vectorized tracking for transversedeflectingcavity Fix vectorized tracking for TransverseDeflectingCavity Oct 16, 2024
@jank324 jank324 merged commit 72baff6 into master Oct 16, 2024
8 checks passed
@jank324 jank324 deleted the 270-vectorized-tracking-for-transversedeflectingcavity branch October 16, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorized tracking for TransverseDeflectingCavity
2 participants