-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes to ParticleBeam.plot_distribution
#330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is an example showing the modified plotting, where beam = cheetah.ParticleBeam.from_astra("../tests/resources/ACHIP_EA1_2021.1351.001")
other_beam = beam.transformed_to(sigma_x=beam.sigma_x * 2)
fig, axs = beam.plot_distribution(bin_ranges=None, plot_2d_kws={"style": "histogram"})
_, _ = other_beam.plot_distribution(
bin_ranges=None,
plot_2d_kws={"style": "contour"},
plot_1d_kws={"plot_kws": {"color": "red", "linestyle": "--"}},
axs=axs,
) @jp-ga, @roussel-ryan What do you think? |
@jp-ga ... a little reminder to have a brief look at this |
Hespe
requested changes
Mar 3, 2025
Hespe
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
(%)
from unitless axes, and adds Seaborn-style passing and returning of figures and axes, allowing for easy overlaying of particle distributions, for example to compare ground truths and reconstructions. In line with that, thecontour
argument is also replaced with astyle
argument that one can set to"histogram"
or"contour"
.Motivation and Context
Closes #328 as discussed in the meeting.
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.