Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues when running on a machine with CUDA GPUs #97

Merged
merged 15 commits into from
Nov 17, 2023
Merged

Fix issues when running on a machine with CUDA GPUs #97

merged 15 commits into from
Nov 17, 2023

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Nov 2, 2023 •
edited
Loading

Bug fix for #87

Most important TODOs before merging:

  • Add/update pull request template.
  • Run tests on a CUDA GPU machine, making sure they pass.

Additional TODOs:

  • Update changelog

@jank324 jank324 linked an issue Nov 2, 2023 that may be closed by this pull request
Issues when running on a machine with CUDA GPUs #87
Closed
@jank324 jank324 self-assigned this Nov 2, 2023
@jank324 jank324 requested a review from cr-xu November 2, 2023 09:48
@jank324 jank324 added the bug Something isn't working label Nov 2, 2023
jank324 added a commit that referenced this pull request Nov 2, 2023
@jank324
Update changelog for part of #97
ade914d
@jank324 jank324 mentioned this pull request Nov 2, 2023
Closed
@jank324 jank324 changed the title Add pull request template including note to run tests on GPU Fix issues when running on a machine with CUDA GPUs Nov 2, 2023
@jank324 jank324 marked this pull request as ready for review November 2, 2023 19:45
@jank324 jank324 mentioned this pull request Nov 8, 2023
Closed
6 tasks
@cr-xu cr-xu merged commit 40c6d04 into master Nov 17, 2023
@jank324 jank324 deleted the 87-issues-when-running-on-a-machine-with-cuda-gpus branch June 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr-xu cr-xu Awaiting requested review from cr-xu

Assignees

@jank324 jank324

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues when running on a machine with CUDA GPUs
2 participants
@jank324 @cr-xu