Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-utils overwrites .zshrc coming from image built #1069

Merged
merged 13 commits into from
Aug 13, 2024
Merged

common-utils overwrites .zshrc coming from image built #1069

merged 13 commits into from
Aug 13, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

@prathameshzarkar9 prathameshzarkar9 commented Jul 31, 2024 •
edited
Loading

Issue 1035
common-utils overwrites .zshrc coming from image built with common-utils already

Feature Name

  • common-utils

Changelog

  • Changes to main.sh for features issue

Checklist

  • user provided commands appended to .zshrc file should not overwrite

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner July 31, 2024 10:37
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Jul 31, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes Aug 6, 2024
View reviewed changes
@prathameshzarkar9 prathameshzarkar9 force-pushed the zshrc-overwrite-issue-fix branch from 80b6618 to 4edb37b Compare August 7, 2024 17:39
@prathameshzarkar9 prathameshzarkar9 force-pushed the zshrc-overwrite-issue-fix branch from 4edb37b to 26e6306 Compare August 8, 2024 15:25
samruddhikhandale
samruddhikhandale requested changes Aug 9, 2024
View reviewed changes
samruddhikhandale
samruddhikhandale approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@samruddhikhandale samruddhikhandale merged commit 56233fd into devcontainers:main Aug 13, 2024
12 checks passed
@Mark-J-Lawrence
Copy link

I think this change has broken devcontainers using ghcr.io/devcontainers/features/node:1. node & npm are not found after building the container

I have had to specify ghcr.io/devcontainers/features/common-utils:2.4.5 to get it building with node & npm again.

samruddhikhandale added a commit that referenced this pull request Aug 15, 2024
@samruddhikhandale
Revert "common-utils overwrites .zshrc coming from image built (#1069)"
cdc1313 
This reverts commit 56233fd.
@samruddhikhandale samruddhikhandale mentioned this pull request Aug 15, 2024
Merged
samruddhikhandale added a commit that referenced this pull request Aug 15, 2024
@samruddhikhandale
Revert "common-utils overwrites .zshrc coming from image built" (#1094)
28ca71a 
* Revert "common-utils overwrites .zshrc coming from image built (#1069)"

This reverts commit 56233fd.

* Update devcontainer-feature.json
This was referenced Aug 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prathameshzarkar9 @Mark-J-Lawrence @samruddhikhandale