Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt latest api commit #112

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

yangcao77
Copy link
Collaborator

Signed-off-by: Stephanie yangcao@redhat.com

What does this PR do?:

This PR adpot latest api commit that contains the change to validator returned error.

Which issue(s) this PR fixes:

Fixes devfile/api#577

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@yangcao77 yangcao77 requested a review from maysunfaisal August 12, 2021 19:29
@openshift-ci openshift-ci bot requested review from elsony and kim-tsao August 12, 2021 19:29
Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77 yangcao77 force-pushed the 577-adopt-latest-api branch from 1f66a59 to e17ebc8 Compare August 12, 2021 19:47
@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit 436fb41 into devfile:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validator should not return an error if no default command, should return warning instead
2 participants