Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied code from pkg/errors and use it as go module #15

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Jul 23, 2020

What does this PR do?

It removes copied code from pkg/errors and use it as go module.
Review only one commit ac503fd. See below why.

Let me know if there is any reason not to use pkg/errors in that way.

Which issue/PR does this PR reference?

N/A

@sleshchenko sleshchenko changed the title Remove copied code from pkg/errors and use it as go module 🚧 Remove copied code from pkg/errors and use it as go module Jul 23, 2020
@sleshchenko sleshchenko changed the title 🚧 Remove copied code from pkg/errors and use it as go module Remove copied code from pkg/errors and use it as go module Jul 24, 2020
Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i was able to build the binary after checking out.

@ranakan19 ranakan19 merged commit d8737d0 into devfile:master Jul 24, 2020
@sleshchenko sleshchenko deleted the pkg_errors branch July 27, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants