-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mock interface and avoid validating tokens #178
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 59.72% 60.84% +1.12%
==========================================
Files 41 41
Lines 5125 5006 -119
==========================================
- Hits 3061 3046 -15
+ Misses 1868 1767 -101
+ Partials 196 193 -3
☔ View full report in Codecov by Sentry. |
@@ -13,7 +13,7 @@ | |||
// See the License for the specific language governing permissions and | |||
// limitations under the License. | |||
|
|||
package git | |||
package util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why we decided to move here in this pkg.. Seems like they could be in git pkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, there were duplicates of the until functions in the git package because of cyclic dependencies. It was confusing because some of the parser code was using the same named functions in the util package while others were using the ones from the git package.
Signed-off-by: Kim Tsao <ktsao@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Which issue(s) this PR fixes:
devfile/api#1216
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: