Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools week] Update OWNERS file & update release section #181

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Sep 12, 2023

What does this PR do?:

  • Includes all team inside OWNERS file
  • Updates the release section inside README.md with a list of steps to create a new release. It also mentions explicitly that releases are created on demand.

Which issue(s) this PR fixes:

task of devtools week sep 2023

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: thepetk <thepetk@gmail.com>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99a3776) 60.84% compared to head (c1855f0) 60.84%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   60.84%   60.84%           
=======================================
  Files          41       41           
  Lines        5006     5006           
=======================================
  Hits         3046     3046           
  Misses       1767     1767           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk changed the title [devtools week] Update OWNERS file [devtools week] Update OWNERS file & update release section Sep 12, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk requested a review from kim-tsao September 12, 2023 13:34
Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit efff858 into devfile:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants