Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container can mount same vol at multiple places #75

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Mar 22, 2021

Signed-off-by: Maysun J Faisal maysunaneek@gmail.com

What does this PR do?

When reviewing PR redhat-developer/odo#4465, noticed that a same volume can be mounted at diff locations. So it is not right to return the first mount path, we should return an array of all the mount paths for a specified container component

components:
  - name: test2
    volume:
        size: 1Gi
  - name: test
    container:
        image: xyz
        volumeMounts:
           - name: test2
             path: /path1
           - name: test2
             path: /path2
  - name: test3
    container:
        image: xyz
        volumeMounts:
           - name: test2
             path: /path1
           - name: test2
             path: /path2

What issues does this PR fix or reference?

Is your PR tested? Consider putting some instruction how to test your changes

updated tests

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit 3d70885 into devfile:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants