restricts registryURL format #76
Merged
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <yangcao@redhat.com>
| @@ -2983,6 +2983,7 @@ func Test_parseFromRegistry(t *testing.T) { | |||
| wantDevFile: parentDevfile, | |||
| registryUrl: registry, | |||
| registryId: registryId, | |||
| wantErr: true, | |||
There was a problem hiding this comment.
test title should be should NOT be able to parse from provided registryUrl without prefix
Signed-off-by: Stephanie <yangcao@redhat.com>
maysunfaisal
approved these changes
Mar 25, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie yangcao@redhat.com
What does this PR do?
This PR restricts the
registryURLformat, protocol is expected to be included as part of theregistryURLSince the filed is
registryURL, it is expected to follow the url format. library does not need to help resolve the format, and should not take registry host as the urlWhat issues does this PR fix or reference?
Fixes devfile/api#386
Is your PR tested? Consider putting some instruction how to test your changes
Update unit tests