Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl: Introduce ability to define Functions on Subdomains #2245

Merged
merged 34 commits into from
Mar 4, 2025

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Oct 24, 2023

Add Functions on SubDomains functionality.

Remaining todo (for future PRs I think):

  • MPI in full mode + functions on subdomains leads to an error which I haven't had time to debug

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: Patch coverage is 97.47145% with 31 lines in your changes missing coverage. Please review.

Project coverage is 87.52%. Comparing base (34dba05) to head (3b8ec13).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
devito/types/grid.py 84.15% 14 Missing and 2 partials ⚠️
devito/mpi/distributed.py 95.12% 4 Missing and 2 partials ⚠️
devito/types/sparse.py 20.00% 4 Missing ⚠️
devito/data/decomposition.py 97.29% 0 Missing and 1 partial ⚠️
devito/deprecations.py 75.00% 1 Missing ⚠️
tests/test_interpolation.py 99.55% 0 Missing and 1 partial ⚠️
tests/test_mpi.py 98.82% 0 Missing and 1 partial ⚠️
tests/test_subdomains.py 99.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   87.29%   87.52%   +0.22%     
==========================================
  Files         238      238              
  Lines       46063    47034     +971     
  Branches     4080     4144      +64     
==========================================
+ Hits        40211    41165     +954     
- Misses       5162     5176      +14     
- Partials      690      693       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout added the API api (symbolics, types, ...) label Oct 24, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EdCaunt EdCaunt added the WIP Still work in progress label Dec 13, 2023
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the amount of changes introduced, I'd prefer to see a lot more new tests.

Shouldn't all (most) of the old tests that @rhodrin wrote be here as well?

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick pass

@EdCaunt EdCaunt requested a review from mloubout April 4, 2024 13:01
@EdCaunt EdCaunt removed the WIP Still work in progress label Apr 4, 2024
@EdCaunt EdCaunt force-pushed the funcs_on_subdims branch from 4268c54 to af06ba9 Compare April 8, 2024 15:41
EdCaunt and others added 26 commits March 4, 2025 11:42
@EdCaunt EdCaunt force-pushed the funcs_on_subdims branch from 08a4f5b to 3b8ec13 Compare March 4, 2025 11:42
@FabioLuporini FabioLuporini merged commit f854b0c into master Mar 4, 2025
31 checks passed
@FabioLuporini FabioLuporini deleted the funcs_on_subdims branch March 4, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants