-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl: Introduce ability to define Functions on Subdomains #2245
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 87.29% 87.52% +0.22%
==========================================
Files 238 238
Lines 46063 47034 +971
Branches 4080 4144 +64
==========================================
+ Hits 40211 41165 +954
- Misses 5162 5176 +14
- Partials 690 693 +3 ☔ View full report in Codecov by Sentry. |
5fc54ee
to
a0742f0
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
9fe8916
to
1092e78
Compare
1d37846
to
d462af1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the amount of changes introduced, I'd prefer to see a lot more new tests.
Shouldn't all (most) of the old tests that @rhodrin wrote be here as well?
588c25e
to
2cd952e
Compare
2cd952e
to
341ee08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick pass
4268c54
to
af06ba9
Compare
08a4f5b
to
3b8ec13
Compare
Add Functions on SubDomains functionality.
Remaining todo (for future PRs I think):