Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme v2.0 #381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aguero-tech
Copy link

@vbakke & @wurstbrot thanks for the feedback on #374, since we are making major angular upgrades, i took off the matrix buttons, so this PR solely focuses on dark theme improvements.

  1. Moved light/dark toggle button to the side nav
  2. icon toggle colors match the theme.
  3. changed the background and headings of text/drawers (in dark mode)
  4. made the heatmap gridlines & text white to contrast with dark background (in dark mode).

Sorry i did not change the DSOMM in black on the top left. I think it looks pretty rad, and i didn't want to load another image lol.
image

@aguero-tech aguero-tech marked this pull request as ready for review March 25, 2025 21:31
@aguero-tech
Copy link
Author

image

@wurstbrot wurstbrot requested a review from 0x41head March 29, 2025 16:32
@vbakke
Copy link
Collaborator

vbakke commented Mar 30, 2025

@aguero-tech , I created a pull request to your pull request, where the circular heatmap is drawn in dark / light mode.

However, switching the light mode from the menu, currently does not update the setting of the circular component. Are you able to pass on the switch to the circular component?

@vbakke
Copy link
Collaborator

vbakke commented Mar 30, 2025

@aguero-tech , looks like adding the 'Switch to Dark Mode' is breaking the unittest check for navigation names being shown in the same order as options array.

@0x41head: I'm a bit unsure about the benefit of this test, and what sort of mistakes this test is supposed to uncover. Is it meaningful?

@aguero-tech
Copy link
Author

Thank you @vbakke . I apologize. im out for the weekend. Will touch base on Tuesday. I'll look into the menu unit test break as well and see if I can ameliorate it or find some enlightenment about the purpose of the test as well. I appreciate it.

@vbakke
Copy link
Collaborator

vbakke commented Mar 31, 2025

Not to worry @aguero-tech . I think I broke everything that cold be broken on my first PR. : )

Nor is this any rush. You're doing it in your spare time. Do it when time allows 🙂

@0x41head
Copy link
Collaborator

fixed the unit test @vbakke @aguero-tech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants