Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autoselect node,error messaging improvement , node group and custom shell support #2925

Merged
merged 62 commits into from
Mar 6, 2023
Merged

feat: autoselect node,error messaging improvement , node group and custom shell support #2925

merged 62 commits into from
Mar 6, 2023

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Feb 3, 2023 •
edited
Loading

Description

  • added autoselect node option.
  • error messaging improvement for pod terminate state.
  • node group and custom shell support.

Fixes #3079

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested by QA

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu gireesh-naidu changed the title Autoselect node fix: Autoselect node Feb 3, 2023
@gireesh-naidu gireesh-naidu changed the title fix: Autoselect node feat: autoselect node and error messaging improvement Feb 3, 2023
@gireesh-naidu gireesh-naidu marked this pull request as ready for review February 20, 2023 04:35
@gireesh-naidu gireesh-naidu changed the title feat: autoselect node,error messaging improvement and custom shell support feat: autoselect node,error messaging improvement , node group and custom shell support Feb 20, 2023
@gireesh-naidu gireesh-naidu linked an issue Mar 6, 2023 that may be closed by this pull request
Feature: Cluster terminal Iteration 2 #3079
Closed
2 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-naidu gireesh-naidu merged commit 22f42be into main Mar 6, 2023
@gireesh-naidu gireesh-naidu deleted the autoselect_node branch March 6, 2023 14:50
@vikramdevtron vikramdevtron mentioned this pull request Apr 28, 2023
Closed
2 tasks
@gireesh-naidu gireesh-naidu mentioned this pull request Apr 28, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Cluster terminal Iteration 2
2 participants
@gireesh-naidu @kripanshdevtron