feat: deployment pipeline partially delete. #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talled app, added new request for paritally delete
iamayushm
changed the title
iamayushm
changed the title
…cd-app-partially-delete
| @@ -401,6 +404,12 @@ func (handler *InstalledAppRestHandlerImpl) FetchAppDetailsForInstalledApp(w htt | |||
| } | |||
| handler.Logger.Infow("request payload, FetchAppDetailsForInstalledApp, app store", "installedAppId", installedAppId, "envId", envId) | |||
|
|
|||
| err = handler.installedAppService.CheckAppExistsByInstalledAppId(installedAppId) | |||
| if err == pg.ErrNoRows { | |||
There was a problem hiding this comment.
avoid this check in rest handler, handle it in service layer.
| @@ -425,16 +434,33 @@ func (handler *InstalledAppRestHandlerImpl) FetchAppDetailsForInstalledApp(w htt | |||
| } | |||
| //rback block ends here | |||
| if len(appDetail.AppName) > 0 && len(appDetail.EnvironmentName) > 0 { | |||
| handler.fetchResourceTree(w, r, &appDetail) | |||
| err = handler.fetchResourceTree(w, r, &appDetail) | |||
There was a problem hiding this comment.
can we move this logic at service layer
| @@ -355,6 +356,20 @@ func (handler AppListingRestHandlerImpl) FetchAppDetails(w http.ResponseWriter, | |||
| common.WriteJsonResp(w, err, nil, http.StatusBadRequest) | |||
| return | |||
| } | |||
| pipelines, err := handler.pipelineRepository.FindActiveByAppIdAndEnvironmentId(appId, envId) | |||
There was a problem hiding this comment.
we have to move this logic in service
vikramdevtron
previously approved these changes
Feb 20, 2023
iamayushm
changed the title
# Conflicts: # api/restHandler/AppListingRestHandler.go # internal/sql/repository/pipelineConfig/PipelineRepository.go # pkg/app/AppService.go # pkg/bean/app.go # pkg/pipeline/GitopsOrHelmOption_test.go # pkg/pipeline/PipelineBuilder.go # wire_gen.go
|
SonarCloud Quality Gate failed.
|
vikramdevtron
approved these changes
Feb 27, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing case where deletion get stuck, the argo app is not actually deleted but it is deleted at devtron side. This causes error when user tries to recreate the pipeline.
Fixes #2746
tech doc: https://docs.google.com/document/d/1XrOChkOvShkpk0oNr-BqXT4jerOizgSza1Xw6naSN9E/edit
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?